refactor(components): [tabs] enhance instance type #14352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. exports Tabs instance type 2. add expose type to TabNavInstanec
|
|
|
🧪 Playground Preview: https://element-plus.run/?pr=14352 |
btea
approved these changes
Sep 21, 2023
ryuhangyeong
approved these changes
Sep 22, 2023
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
* refactor(components): [tabs] enhance instance type 1. exports Tabs instance type 2. add expose type to TabNavInstanec * chore: remove useless import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exports Tabs instance type
add expose type to TabNavInstanec
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.Description
🤖 Generated by Copilot at 036975d
Improved the type definitions and circular dependency handling of the
TabsandTabNavcomponents. Added acurrentNameproperty toTabsand exposed two methods fromTabNavto control scrolling and focus.Related Issue
Fixes #___.
Explanation of Changes
🤖 Generated by Copilot at 036975d
scrollToActiveTabandremoveFocusmethods fromTabNavcomponent to allow parentTabscomponent to control scrolling and focus behavior (link, link, link)Tabscomponent to a constant and export it as default to avoid circular dependency issue withTabNavcomponent, which imports theTabstype (link, link)TabsInstancetype to extend the instance type ofTabscomponent with acurrentNameproperty, which reflects the name of the active tab pane (link)