Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [date-picker] slot compatible with Vue3.3.x #14354

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

FrontEndDog
Copy link
Member

@FrontEndDog FrontEndDog commented Sep 21, 2023

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at 9592d64

Fix a bug with the date picker component when using v-if inside the cell slot. Filter out the virtual comment nodes from the cell render function in basic-cell-render.tsx.

Related Issue

Fixes #14342 .

Explanation of Changes

🤖 Generated by Copilot at 9592d64

  • Fix a bug with the date picker when using v-if inside the cell slot by filtering out the virtual comment nodes (link)

@pull-request-triage
Copy link

👋 @FrontEndDog, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Sep 21, 2023
@github-actions
Copy link

github-actions bot commented Sep 21, 2023

@github-actions
Copy link

Hello @FrontEndDog, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Sep 21, 2023
@FrontEndDog
Copy link
Member Author

the type of virtual nodes in Vue3.2 is Symbol(Comment),but in Vue3.3 is Symbol(v-cmt).It resulting in not displaying the date when writing empty nodes or explanator in the date-picker default slot.
image
image

@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=14354
Please comment the example via this playground if needed.

Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tolking tolking merged commit 9b9b657 into element-plus:dev Oct 4, 2023
13 checks passed
@element-bot element-bot mentioned this pull request Oct 13, 2023
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] [date-picker] el-date-picker无法显示日期
3 participants