Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [popper] invalid when props z-index is zero #14375

Merged
merged 1 commit into from
Oct 1, 2023
Merged

fix(components): [popper] invalid when props z-index is zero #14375

merged 1 commit into from
Oct 1, 2023

Conversation

betavs
Copy link
Contributor

@betavs betavs commented Sep 22, 2023

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

[popper] invalid when props z-index is zero

Related Issue

Fixes #___.

Explanation of Changes

[popper] invalid when props z-index is zero

@pull-request-triage
Copy link

👋 @betavs, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Sep 22, 2023
@github-actions
Copy link

github-actions bot commented Sep 22, 2023 •
edited

@github-actions
Copy link

Hello @betavs, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Sep 22, 2023
@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=14375
Please comment the example via this playground if needed.

@tolking tolking merged commit a1deb26 into element-plus:dev Oct 1, 2023
12 checks passed
@element-bot element-bot mentioned this pull request Oct 13, 2023
Merged
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
@betavs @dannyhebertbell
fix(components): [popper] invalid when props z-index is zero (element…
de7b423 
…-plus#14375)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolking tolking tolking approved these changes

@btea btea btea approved these changes

Assignees

@betavs betavs

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@betavs @tolking @btea