Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [upload] icon style abnormal #14471

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

betavs
Copy link
Contributor

@betavs betavs commented Oct 8, 2023

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at 04ad110

Fixed upload icon alignment issue by adding a selector to i element in upload.scss. This prevents conflicts with other icons in the upload component.

Related Issue

Fixes #14469

Explanation of Changes

🤖 Generated by Copilot at 04ad110

@pull-request-triage
Copy link

👋 @betavs, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

Hello @betavs, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

🧪 Playground Preview: https://element-plus.run/?pr=14471
Please comment the example via this playground if needed.

@tolking tolking merged commit ef0d582 into element-plus:dev Oct 12, 2023
13 checks passed
@element-bot element-bot mentioned this pull request Oct 13, 2023
3 tasks
cc-hearts pushed a commit to cc-hearts/element-plus that referenced this pull request Oct 15, 2023
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants