feat(docs): theme switch use startViewTransition api #14489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
🧪 Playground Preview: https://element-plus.run/?pr=14489 |
ryuhangyeong
reviewed
Oct 9, 2023
|
@ryuhangyeong It has been confirmed with the designer that we can add this feature. |
|
Rigorous and precise observation.. 👍 |
tolking
reviewed
Oct 11, 2023
docs/.vitepress/vitepress/components/common/vp-theme-toggler.vue
Outdated
Show resolved
Hide resolved
|
@tolking Regarding the problem mentioned by @ryuhangyeong, I haven't found a solution. Do you have any suggestions? 🤔 |
tolking
approved these changes
Oct 12, 2023
|
@ryuhangyeong Maybe we can keep it this way for now? |
ryuhangyeong
approved these changes
Oct 12, 2023
|
Okay, let's merge this pr first. |
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.Description
🤖 Generated by Copilot at 2287219
This pull request enhances the theme toggling feature of the documentation website by adding a smooth animation effect for the
vp-theme-togglercomponent. It also improves the code style and readability of thebase.scssfile. It mainly modifies the filesvp-theme-toggler.vueandbase.scssusing the Transition API.Related Issue
Fixes #___.
Explanation of Changes
🤖 Generated by Copilot at 2287219
nextTickfunction fromvueand addswitchThemeandbeforeChangefunctions to handle theme transition animation using Transition API invp-theme-toggler.vue(link, link)::view-transition-old(root)and::view-transition-new(root)to create theme transition effect depending on dark or light mode inbase.scss(link)base.scss(link, link, link)base.scss(link, link, link)