-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): [select] accessibility enhancement #14503
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tolking
changed the title
feat: accessibility enhancement
feat(components): [select] accessibility enhancement
Oct 10, 2023
🧪 Playground Preview: https://element-plus.run/?pr=14503 |
btea
reviewed
Oct 11, 2023
Co-authored-by: btea <2356281422@qq.com>
btea
reviewed
Oct 12, 2023
btea
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.Description
🤖 Generated by Copilot at ceea20a
This pull request enhances the accessibility and customization of the
select
andscrollbar
components. It addsaria-*
attributes and roles to theselect
component and its options, and uses theuseId
anduseAttrs
hooks to generate unique ids and forward inherited attributes. It also addsstyle
andclass
props to thescrollbar
component and refactors some of its template and logic. It updates the test cases accordingly.Related Issue
Fixes #14437.
Explanation of Changes
🤖 Generated by Copilot at ceea20a
style
andclass
props to scrollbar component to enable customization (link)style
andclass
props to root element of scrollbar component and pass inherited attributes to child component (link, link, link, link, link)useId
hook (link, link, link, link, link, link, link, link, link, link, link, link, link, link)packages/components/select/__tests__/select.test.ts
(link)packages/components/select/src/select.vue
(link)