Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): inconsistent style rounded button #14552

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

cuongle-hdwebsoft
Copy link
Contributor

@cuongle-hdwebsoft cuongle-hdwebsoft commented Oct 15, 2023

fix: inconsistent style rounded button

closed #14550

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at 873a0c7

Fix button size inconsistency across browsers by aligning button width with default input height in button.scss.

Related Issue

Fixes #14550.

Explanation of Changes

🤖 Generated by Copilot at 873a0c7

  • Fix inconsistent button sizes in different browsers by:
    • Setting button width to match default input height (link)

@pull-request-triage
Copy link

👋 @cuongle-hdwebsoft, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Oct 15, 2023

@github-actions
Copy link

Hello @cuongle-hdwebsoft, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=14552
Please comment the example via this playground if needed.

@cuongle-hdwebsoft
Copy link
Contributor Author

Before: demo link
CleanShot 2023-10-15 at 14 16 14@2x

After: demo link
CleanShot 2023-10-15 at 14 15 57@2x

@cuongle-hdwebsoft cuongle-hdwebsoft changed the title fix(components): fix: inconsistent style rounded button fix(components): inconsistent style rounded button Oct 15, 2023
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tolking tolking merged commit 0e9cade into element-plus:dev Oct 15, 2023
13 checks passed
cc-hearts pushed a commit to cc-hearts/element-plus that referenced this pull request Oct 15, 2023
fix(components): fix: inconsistent style rounded button

fix: inconsistent style rounded button

closed element-plus#14550
@element-bot element-bot mentioned this pull request Oct 18, 2023
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
fix(components): fix: inconsistent style rounded button

fix: inconsistent style rounded button

closed element-plus#14550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Style] [button] row加上按钮为圆形会变扁
3 participants