-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components): prevent carousel from auto playing #14553
Conversation
prevent carousel from auto playing closed element-plus#14524
👋 @cuongle-hdwebsoft, thank you for contributing element-plus. |
Hello @cuongle-hdwebsoft, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
🧪 Playground Preview: https://element-plus.run/?pr=14553 |
Here is demo Testing step:
CleanShot.2023-10-15.at.14.05.56.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
prevent carousel from auto playing closed element-plus#14524
prevent carousel from auto playing closed element-plus#14524
prevent carousel from auto playing
closed #14524
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.Description
🤖 Generated by Copilot at 88f2ce6
Fixed a bug in
use-carousel.ts
that ignored thepauseOnHover
prop of the carousel component. This improves the user experience and accessibility of the carousel.Related Issue
Fixes #14524
Explanation of Changes
🤖 Generated by Copilot at 88f2ce6
pauseOnHover
is true (link)