Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [select] style error in multiple collapseTags #14602

Merged
merged 2 commits into from
Nov 11, 2023
Merged

fix(components): [select] style error in multiple collapseTags #14602

merged 2 commits into from
Nov 11, 2023

Conversation

Fuphoenixes
Copy link
Contributor

@Fuphoenixes Fuphoenixes commented Oct 19, 2023

fix: [Component] [select] el-select 设置 multiple collapseTags 为 true 时,tag宽度异常

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at 7181c0f

Fix tag width calculation for select component with multiple and collapse-tags props. Modify tagTextStyle in select.vue and add an assertion in select.test.ts.

Related Issue

Fixes #14601 .

Explanation of Changes

🤖 Generated by Copilot at 7181c0f

  • Fix a bug where the tag max-width was not calculated correctly when the tags were collapsed in the select component (link)
  • Improve the test coverage for the select component with multiple and collapse-tags props (link)

@pull-request-triage
Copy link

👋 @Fuphoenixes, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

Hello @Fuphoenixes, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Oct 19, 2023

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Oct 20, 2023
@github-actions
Copy link

github-actions bot commented Oct 20, 2023

🧪 Playground Preview: https://element-plus.run/?pr=14602
Please comment the example via this playground if needed.

@Fuphoenixes
Copy link
Contributor Author

@btea 为什么这个pr还没合成功?

@btea
Copy link
Collaborator

btea commented Nov 10, 2023

你好,PR 合并之前还需另一个人同意。其他人暂时可能忙于工作来不及查看,请耐心等待。谢谢你的贡献!

@btea btea merged commit 4580aea into element-plus:dev Nov 11, 2023
10 checks passed
@element-bot element-bot mentioned this pull request Nov 27, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] [select] el-select 设置 multiple collapseTags 为 true 时,tag宽度异常
3 participants