-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components): [select] style error in multiple collapseTags #14602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋 @Fuphoenixes, seems like this is your first time contribution to element-plus.
|
pull-request-triage
bot
added
1st contribution
Their very first contribution
Needs Review
labels
Oct 19, 2023
Hello @Fuphoenixes, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
🧪 Playground Preview: https://element-plus.run/?pr=14602 |
btea
approved these changes
Oct 24, 2023
@btea 为什么这个pr还没合成功? |
你好,PR 合并之前还需另一个人同意。其他人暂时可能忙于工作来不及查看,请耐心等待。谢谢你的贡献! |
ryuhangyeong
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1st contribution
Their very first contribution
CommitMessage::Qualified
Qualified commit message
Contribution::Community
Needs Review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: [Component] [select] el-select 设置 multiple collapseTags 为 true 时,tag宽度异常
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.Description
🤖 Generated by Copilot at 7181c0f
Fix tag width calculation for select component with multiple and collapse-tags props. Modify
tagTextStyle
inselect.vue
and add an assertion inselect.test.ts
.Related Issue
Fixes #14601 .
Explanation of Changes
🤖 Generated by Copilot at 7181c0f