Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [tree-select] case-insensitive when filterable #14617

Merged

Conversation

hellomrbigshot
Copy link
Contributor

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at 304bdc5

Enhanced the filter functionality and code style of the tree-select component.

Related Issue

Fixes #14613 .

Explanation of Changes

🤖 Generated by Copilot at 304bdc5

  • Import escapeStringRegexp function from @element-plus/utils to escape special characters in filter value for tree-select component (link)
  • Change filter logic to use case-insensitive regular expression instead of string inclusion check, to improve user experience and match behavior of other components (link)
  • Adjust indentation of ternary operators and filter function to follow code style of project (link, link, link, link)

@pull-request-triage
Copy link

👋 @hellomrbigshot, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Oct 22, 2023

@github-actions
Copy link

Hello @hellomrbigshot, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=14617
Please comment the example via this playground if needed.

@kooriookami
Copy link
Member

LGTM

@kooriookami kooriookami merged commit 553fe41 into element-plus:dev Jan 6, 2024
12 checks passed
@element-bot element-bot mentioned this pull request Jan 10, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] [tree-select] tree-select case-sensitive when filterable
2 participants