Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(components): [slider] use new display tag #14711

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

wzc520pyfm
Copy link
Contributor

@wzc520pyfm wzc520pyfm commented Oct 31, 2023

Related: #10754

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at 44cdd89

This pull request adds and updates comments and documentation for the Slider component. It enhances the code readability and the API generation for the sliderProps object in ./packages/components/slider/src/slider.ts. It also revises the documentation format and content in ./docs/en-US/component/slider.md to match the new API and fix some errors.

Related Issue

Fixes #___.

Explanation of Changes

🤖 Generated by Copilot at 44cdd89

  • Update the documentation of the Slider component in ./docs/en-US/component/slider.md to use the new API format and fix typos and inconsistencies (link)
  • Add description comments for the props in the SliderInitData interface and the sliderProps object in packages/components/slider/src/slider.ts to document the code and provide information for the type inference and the API generation (link, link, link)

Copy link

👋 @wzc520pyfm, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

Copy link

github-actions bot commented Oct 31, 2023

Copy link

Hello @wzc520pyfm, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Oct 31, 2023
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=14711
Please comment the example via this playground if needed.

@tolking tolking merged commit 6542286 into element-plus:dev Dec 3, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants