-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components): [table] tooltipOptions.showAfter is not effective #14741
Conversation
tooltipOptions.showAfter is not effective
👋 @xingyixiang, seems like this is your first time contribution to element-plus.
|
Hello @xingyixiang, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
🧪 Playground Preview: https://element-plus.run/?pr=14741 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is this a normal behavior? 2023-12-01.10.13.01.mp4 |
@tolking Is that the same before the modification? I didn't reproduce the problem in the video with the current pr. |
It is a problem that occurred after modification |
@tolking ok |
rolling unable to destroy Popper
@tolking The problem has been fixed |
@tolking Please help me review it again. Thanks |
@kooriookami @tolking @btea This tooltip needs to be dynamically created and destroyed for performance purposes. The current el-tooltip does not seem to have this ability. |
@tolking @kooriookami @btea el-tootip's singleton mode seems to do it. I'll study it sometime. |
@kooriookami @btea #15179 The overflowTooltip is implemented using ElTooltip. |
tooltipOptions.showAfter is not effective
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.Description
🤖 Generated by Copilot at 75d8990
Improved and fixed tooltip for table component. Added
showAfter
option toutil.ts
and simplified popper events.Related Issue
Fixes #___.
Explanation of Changes
🤖 Generated by Copilot at 75d8990
togglePopperVisible
function to show or hide popper element based onshowAfter
option of tooltip (link, link)onOpen
andonClose
handlers for content element and only add mouse events ifenterable
option is truthy (link)onOpen
handler when popper is created to trigger popper visibility logic (link)