Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [table] tooltipOptions.showAfter is not effective #14741

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

xingyixiang
Copy link
Contributor

@xingyixiang xingyixiang commented Nov 4, 2023

tooltipOptions.showAfter is not effective

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at 75d8990

Improved and fixed tooltip for table component. Added showAfter option to util.ts and simplified popper events.

Related Issue

Fixes #___.

Explanation of Changes

🤖 Generated by Copilot at 75d8990

  • Add and use togglePopperVisible function to show or hide popper element based on showAfter option of tooltip (link, link)
  • Simplify onOpen and onClose handlers for content element and only add mouse events if enterable option is truthy (link)
  • Call onOpen handler when popper is created to trigger popper visibility logic (link)

tooltipOptions.showAfter is not effective
Copy link

👋 @xingyixiang, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Nov 4, 2023
Copy link

github-actions bot commented Nov 4, 2023

Copy link

github-actions bot commented Nov 4, 2023

Hello @xingyixiang, thank you for contributing to element-plus, please see our guideline to see how to make contribution

Copy link

github-actions bot commented Nov 4, 2023

🧪 Playground Preview: https://element-plus.run/?pr=14741
Please comment the example via this playground if needed.

@xingyixiang
Copy link
Contributor Author

xingyixiang commented Nov 4, 2023

Playground

Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tolking
Copy link
Member

tolking commented Dec 1, 2023

Is this a normal behavior?

2023-12-01.10.13.01.mp4

@xingyixiang
Copy link
Contributor Author

xingyixiang commented Dec 1, 2023

@tolking Is that the same before the modification? I didn't reproduce the problem in the video with the current pr.
Playground

@tolking
Copy link
Member

tolking commented Dec 1, 2023

It is a problem that occurred after modification

Link

@xingyixiang
Copy link
Contributor Author

@tolking ok

@xingyixiang
Copy link
Contributor Author

@tolking The problem has been fixed

@xingyixiang
Copy link
Contributor Author

@tolking Please help me review it again. Thanks

@xingyixiang
Copy link
Contributor Author

xingyixiang commented Dec 5, 2023

@btea @tolking Can it be incorporated in the next version?

@btea btea requested a review from kooriookami December 6, 2023 01:31
@kooriookami
Copy link
Member

@btea @tolking I wonder can we replace with el-tooltip?

@xingyixiang
Copy link
Contributor Author

@kooriookami @tolking @btea This tooltip needs to be dynamically created and destroyed for performance purposes. The current el-tooltip does not seem to have this ability.

@xingyixiang
Copy link
Contributor Author

xingyixiang commented Dec 6, 2023

@tolking @kooriookami @btea el-tootip's singleton mode seems to do it. I'll study it sometime.

@btea btea merged commit b6b98bb into element-plus:dev Dec 6, 2023
10 checks passed
@element-bot element-bot mentioned this pull request Dec 15, 2023
3 tasks
@xingyixiang
Copy link
Contributor Author

@kooriookami @btea #15179 The overflowTooltip is implemented using ElTooltip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants