Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(components): [date-picker] use new dispaly tag #14754

Merged
merged 3 commits into from
Nov 11, 2023

Conversation

wzc520pyfm
Copy link
Contributor

@wzc520pyfm wzc520pyfm commented Nov 6, 2023

Related: #10754

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at 2855a0c

Refactored the props of the time-picker and date-picker components to simplify and improve their API and documentation. Updated the date-picker.md document and added a comment to the type prop of the datePickerProps object.

Related Issue

Fixes #___.

Explanation of Changes

🤖 Generated by Copilot at 2855a0c

  • Update the Attributes section of the date-picker.md document to match the new API format and types of the datePickerProps object (link)
  • Add a description comment to the type prop of the datePickerProps object in the date-picker.ts file (link)
  • Simplify the readonly, disabled, isRange, and arrowControl props of the timePickerDefaultProps object in the common/props.ts file to only include the type and not the default value (link, link, link)

Copy link

👋 @wzc520pyfm, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

Copy link

github-actions bot commented Nov 6, 2023

Hello @wzc520pyfm, thank you for contributing to element-plus, please see our guideline to see how to make contribution

Copy link

github-actions bot commented Nov 6, 2023

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Nov 6, 2023
Copy link

github-actions bot commented Nov 6, 2023

🧪 Playground Preview: https://element-plus.run/?pr=14754
Please comment the example via this playground if needed.

@wzc520pyfm wzc520pyfm requested a review from btea November 7, 2023 13:34
@btea btea merged commit 9d65c0b into element-plus:dev Nov 11, 2023
10 checks passed
ikkkp added a commit to ikkkp/element-plus that referenced this pull request Jan 6, 2024
* refactor(components): [time-picker] update  boolean attr are declared

* docs(components): [date-picker] use new dispaly tag

* docs(components): [date-picker] delete extra description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants