Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): [date-picker] add yearrange date-picker. #6388 #2487 #7051 #2042 #14804

Open
wants to merge 21 commits into
base: dev
Choose a base branch
from

Conversation

CherishTheYouth
Copy link
Contributor

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

Add type yearrange for date-picker

Related Issue

Feat #6388 #2487 #7051 #2042

Explanation of Changes

I implement this feature based on the monthrange and daterange date-picker with typescript.

Copy link

👋 @CherishTheYouth, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Nov 10, 2023
Copy link

Hello @CherishTheYouth, thank you for contributing to element-plus, please see our guideline to see how to make contribution

Copy link

github-actions bot commented Nov 10, 2023

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Nov 25, 2023
Copy link

github-actions bot commented Nov 25, 2023

🧪 Playground Preview: https://element-plus.run/?pr=14804
Please comment the example via this playground if needed.

Copy link
Member

@FrontEndDog FrontEndDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! It would be even better if you could add a test case!

docs/examples/button/click-auto-blur.vue Outdated Show resolved Hide resolved
@CherishTheYouth
Copy link
Contributor Author

Thanks for your contribution! It would be even better if you could add a test case!

I will make time to add test case, thank you!

@lzw-leaf
Copy link

╯︿╰,when will this commit be ready for production?

@CherishTheYouth
Copy link
Contributor Author

╯︿╰,when will this commit be ready for production?

抱歉哈,我还以为没人关注这个feature呢,我尽快弄下

@CherishTheYouth
Copy link
Contributor Author

╯︿╰,when will this commit be ready for production?

抱歉哈,我还以为没人关注这个feature呢,我尽快弄下了

Thanks for your contribution! It would be even better if you could add a test case!

I have add some test cases just now, and it passed.

@CherishTheYouth CherishTheYouth removed their assignment Jun 19, 2024
@CherishTheYouth
Copy link
Contributor Author

@FrontEndDog @btea Would you mind reviewing this pr in your free time, much appreciate. 感激!

@hibichann
Copy link

hibichann commented Jun 20, 2024

i really need this feature, BTW there is a bug when change type from year/years to *range at shortcuts value callback(sadly, the best choice for me is yearrange, but i cant), im going to issue it at this weekend

@ZhangYC193
Copy link

i really need this feature, BTW there is a bug when change type from year/years to *range at shortcuts value callback(sadly, the best choice for me is yearrange, but i cant), im going to issue it at this weekend

me too

@CherishTheYouth
Copy link
Contributor Author

i really need this feature, BTW there is a bug when change type from year/years to *range at shortcuts value callback(sadly, the best choice for me is yearrange, but i cant), im going to issue it at this weekend

me too

我有基于 element-plus 写的本地版本,你要吗,这个pr不知道什么时候能合入,最早估计也要等下一个小版本了

@hibichann
Copy link

i really need this feature, BTW there is a bug when change type from year/years to *range at shortcuts value callback(sadly, the best choice for me is yearrange, but i cant), im going to issue it at this weekend

me too

我有基于 element-plus 写的本地版本,你要吗,这个pr不知道什么时候能合入,最早估计也要等下一个小版本了

不太好,还是得从仓库下

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants