-
-
Notifications
You must be signed in to change notification settings - Fork 15.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): [date-picker] add yearrange date-picker. #6388 #2487 #7051 #2042 #14804
base: dev
Are you sure you want to change the base?
Conversation
👋 @CherishTheYouth, seems like this is your first time contribution to element-plus.
|
Hello @CherishTheYouth, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
🧪 Playground Preview: https://element-plus.run/?pr=14804 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! It would be even better if you could add a test case!
I will make time to add test case, thank you! |
╯︿╰,when will this commit be ready for production? |
抱歉哈,我还以为没人关注这个feature呢,我尽快弄下 |
Merge branch 'feat/yearrange' of https://github.com/CherishTheYouth/element-plus-yearrange into feat/yearrange
抱歉哈,我还以为没人关注这个feature呢,我尽快弄下了
I have add some test cases just now, and it passed. |
@FrontEndDog @btea Would you mind reviewing this pr in your free time, much appreciate. 感激! |
i really need this feature, BTW there is a bug when change type from year/years to *range at shortcuts value callback(sadly, the best choice for me is yearrange, but i cant), im going to issue it at this weekend |
packages/components/date-picker/src/date-picker-com/basic-year-table.vue
Outdated
Show resolved
Hide resolved
packages/components/date-picker/src/date-picker-com/panel-year-range.vue
Outdated
Show resolved
Hide resolved
packages/components/date-picker/src/date-picker-com/basic-year-table.vue
Outdated
Show resolved
Hide resolved
Merge branch 'feat/yearrange' of https://github.com/CherishTheYouth/element-plus-yearrange into feat/yearrange
me too |
我有基于 element-plus 写的本地版本,你要吗,这个pr不知道什么时候能合入,最早估计也要等下一个小版本了 |
不太好,还是得从仓库下 |
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.Description
Add type
yearrange
for date-pickerRelated Issue
Feat #6388 #2487 #7051 #2042
Explanation of Changes
I implement this feature based on the
monthrange
anddaterange
date-picker with typescript.