Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [watermark] mutationObserver should work #14822

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

Fuphoenixes
Copy link
Contributor

@Fuphoenixes Fuphoenixes commented Nov 13, 2023

closed #14819

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at 7b8a093

Enhance watermark component to handle dynamic elements. Add subtree and childList options to MutationObserver in watermark.vue.

Related Issue

Fixes #14819 .

Explanation of Changes

🤖 Generated by Copilot at 7b8a093

  • Add two options to the MutationObserver constructor to monitor dynamic changes in the target container (link)

Copy link

👋 @Fuphoenixes, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

Copy link

github-actions bot commented Nov 13, 2023

Copy link

Hello @Fuphoenixes, thank you for contributing to element-plus, please see our guideline to see how to make contribution

Copy link

🧪 Playground Preview: https://element-plus.run/?pr=14822
Please comment the example via this playground if needed.

Copy link
Member

@ryuhangyeong ryuhangyeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomatoDroid

Could you consider this review?

@btea btea changed the title fix(components): mutationObserver should work fix(components): [watermark] mutationObserver should work Nov 14, 2023
@Fuphoenixes
Copy link
Contributor Author

Fuphoenixes commented Nov 28, 2023

这个pr可以合了吗?水印组件无法防篡改应该算是这个组件比较严重的问题 @btea @ryuhangyeong @TomatoDroid

@tolking tolking merged commit 6594757 into element-plus:dev Dec 4, 2023
13 checks passed
@element-bot element-bot mentioned this pull request Dec 15, 2023
3 tasks
@tenglongwentian
Copy link

为什么图片和文字水印不能组合使用?当图片水印存在的时候,文字水印就看不到。无法共存

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] [watermark] 水印组件 MutationObserver 未生效无法做到防止篡改水印
5 participants