Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Algolia highlight error #14831

Merged

Conversation

FrontEndDog
Copy link
Member

@FrontEndDog FrontEndDog commented Nov 15, 2023

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

Before repair

image

After repair

image

__v may have the same effect as key in vue

🤖 Generated by Copilot at 2322da5

Fix search results bug in vp-search.vue component. Pass __v property to parent node to trigger reactivity.

Related Issue

Fixes #___.

Explanation of Changes

🤖 Generated by Copilot at 2322da5

  • Fix search results not updating on query change (link)

Copy link

👋 @FrontEndDog, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

Copy link

github-actions bot commented Nov 15, 2023

Copy link

Hello @FrontEndDog, thank you for contributing to element-plus, please see our guideline to see how to make contribution

Copy link

🧪 Playground Preview: https://element-plus.run/?pr=14831
Please comment the example via this playground if needed.

@FrontEndDog
Copy link
Member Author

@btea @tolking this PR fixed the highlighting error during the search.

@kooriookami kooriookami merged commit 7df7461 into element-plus:dev Dec 5, 2023
13 checks passed
@element-bot element-bot mentioned this pull request Dec 15, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants