Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components): [select] add header and footer slot #14876

Merged
merged 6 commits into from
Nov 27, 2023
Merged

feat(components): [select] add header and footer slot #14876

merged 6 commits into from
Nov 27, 2023

Conversation

Cheerwhy
Copy link
Contributor

@Cheerwhy Cheerwhy commented Nov 20, 2023 •
edited

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖[deprecated] Generated by Copilot at fa9dccf

This pull request adds header and footer slots to the Select component, allowing users to customize the content of the dropdown menu. It updates the documentation, the examples, and the styles to support this feature. It also modifies the SelectDropdown component to render the slots if they are provided.

Related Issue

Fixes #___.

Explanation of Changes

🤖[deprecated] Generated by Copilot at fa9dccf

  • Add header and footer slots to Select component (link, link, link, link, link)
  • Add style variables and rules for the header and footer of the dropdown menu (link, link)

@pull-request-triage Pull Request Triage
Copy link

👋 @Cheerwhy, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2023 •
edited

@github-actions GitHub Actions
Copy link

Hello @Cheerwhy, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@Cheerwhy Cheerwhy changed the title feat(components): [select] add header and footer slot feat(components): [select] add header and footer slot to dropdown Nov 20, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2023 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=14876
Please comment the example via this playground if needed.

@Cheerwhy Cheerwhy changed the title feat(components): [select] add header and footer slot to dropdown feat(components): [select] add header and footer slot Nov 20, 2023
Cheerwhy
Cheerwhy commented Nov 21, 2023
View reviewed changes
Copy link
Contributor Author

@Cheerwhy Cheerwhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@Cheerwhy
Copy link
Contributor Author

Preview Link

ryuhangyeong
ryuhangyeong approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@ryuhangyeong ryuhangyeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find that feature useful. 👍

btea
btea reviewed Nov 26, 2023
View reviewed changes
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few minor suggestions, but other than that, everything else looks pretty good.

docs/en-US/component/select.md Outdated Show resolved Hide resolved
docs/en-US/component/select.md Outdated Show resolved Hide resolved
docs/en-US/component/select.md Outdated Show resolved Hide resolved
docs/en-US/component/select.md Outdated Show resolved Hide resolved
Cheerwhy and others added 2 commits November 27, 2023 14:49
@Cheerwhy @btea
Update docs/en-US/component/select.md
80b59e7 
Co-authored-by: btea <2356281422@qq.com>
@Cheerwhy @btea
Apply suggestions from code review
77facd2 
Co-authored-by: btea <2356281422@qq.com>
@btea btea merged commit f37d056 into element-plus:dev Nov 27, 2023
10 checks passed
@element-bot element-bot mentioned this pull request Nov 27, 2023
Merged
3 tasks
@Hoopex
Copy link

Hoopex commented Dec 2, 2023

@Cheerwhy
Great work, we would like to see this also in select-v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea left review comments

@ryuhangyeong ryuhangyeong ryuhangyeong approved these changes

Assignees

@Cheerwhy Cheerwhy

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Cheerwhy @Hoopex @btea @ryuhangyeong