-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): tour component #14952
Conversation
👋 @Fuphoenixes, thank you for contributing element-plus. |
Hello @Fuphoenixes, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
🧪 Playground Preview: https://element-plus.run/?pr=14952 |
tour_zh-CN.md |
|
@btea do we need this component? |
cc @element-plus/backers |
Wow, it looks great. I tried it simply and found a problem. When using |
thanks, i have already resolved it. |
66eb94f
to
2cb77ef
Compare
sorry, I changed my git account, so I force-pushed a few more times |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I refactored it and then resolved these issues. |
224ba55
to
bb77ff7
Compare
@btea resolved |
9c1dddb
to
6eabbe6
Compare
I think if no other bugs, it can be merged. |
This issue has not been resolved. |
I think this should allow for clicks, which might be useful in some cases. |
I think it's more reasonable not to be clickable. |
How about adding a configuration and letting the user decide? Not clickable by default? |
Yes, This is better. |
Okay, I have added it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, It is great!
Merry Christmas!
382f24d
to
fa42c63
Compare
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.Description
🤖[deprecated] Generated by Copilot at 3aa9d89
This pull request adds a new Tour component to the element-plus library, which allows users to create guided tours for their products. The component consists of a main Tour component and three sub-components: TourStep, TourMask and TourSteps. The pull request also includes the documentation, examples and tests for the component, as well as the necessary changes to the components index file and the component sidebar menu.
Related Issue
Fixes #___.
Explanation of Changes
🤖[deprecated] Generated by Copilot at 3aa9d89