Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(components): [collapse] use new display tag #14955

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

wzc520pyfm
Copy link
Contributor

@wzc520pyfm wzc520pyfm commented Nov 26, 2023

Related: #10754

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖[deprecated] Generated by Copilot at 2b6b746

This pull request adds and improves JSDoc comments for the Collapse component and its subcomponents in the source code and documentation files. This enhances the readability, maintainability, and usability of the component.

Related Issue

Fixes #___.

Explanation of Changes

🤖[deprecated] Generated by Copilot at 2b6b746

  • Add JSDoc comments for collapseProps and collapseItemProps in the source code to generate documentation and provide type hints (link, link)
  • Update collapse.md to clarify the type and default value of model-value / v-model and the type of change event parameter in Collapse Attributes section (link)
  • Update collapse.md to add default values of title and disabled and use consistent spacing for type union of name in Collapse Item Attributes section (link)

Copy link

👋 @wzc520pyfm, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

Copy link

github-actions bot commented Nov 26, 2023

Copy link

Hello @wzc520pyfm, thank you for contributing to element-plus, please see our guideline to see how to make contribution

Copy link

🧪 Playground Preview: https://element-plus.run/?pr=14955
Please comment the example via this playground if needed.

@wzc520pyfm wzc520pyfm changed the title feat(components): [collapse] use new display tag docs(components): [collapse] use new display tag Dec 14, 2023
@ryuhangyeong ryuhangyeong merged commit 3fdab26 into element-plus:dev Dec 26, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants