fix(components): [table-v2] cell, header-cell, empty slots not displayed #15016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @FrontEndDog, thank you for contributing element-plus.
|
|
Hello @FrontEndDog, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
|
|
|
🧪 Playground Preview: https://element-plus.run/?pr=15016 |
FrontEndDog
force-pushed
the
fix-table-v2-slot
branch
from
3da7b6a
to
9f58022
Compare
kooriookami
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.Description
Similar to #14939
test example
🤖[deprecated] Generated by Copilot at 9f58022
This pull request refactors and improves the slot rendering of the table-v2 component by using the
renderSlotfunction fromvuein various components and renderers. It also enhances the test coverage and fixes some minor issues with thecellandheader-cellslots.Related Issue
Fixes #___.
Explanation of Changes
🤖[deprecated] Generated by Copilot at 9f58022
renderSlotfunction for consistent slot rendering and fallback content (link, link, link, link, link, link, link, link)nextTickfunction fromvueintable-v2.test.tsxto test reactivity of slot props (link)cellslot test intable-v2.test.tsxto check custom and default cell elements (link)header-cellslot test intable-v2.test.tsxto check custom and default header cell elements (link)emptyslot test intable-v2.test.tsxto check custom and default empty elements (link)CellRendererParamsandTableV2HeaderCellfromcell.tsxandheader-cell.tsxrespectively (link, link)CellComponentfromcell.tsxand renamecellRenderertocolumnCellRendererto avoid confusion (link, link, link)