Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [data-picker] use renderSlot simplified code #15036

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

FrontEndDog
Copy link
Member

@FrontEndDog FrontEndDog commented Dec 4, 2023

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

Similar to #14939

🤖[deprecated] Generated by Copilot at 2a206e7

Simplify slot rendering in BasicCellRender component. Use renderSlot function from vue to avoid manual slot checking and rendering in packages/components/date-picker/src/date-picker-com/basic-cell-render.tsx.

Related Issue

Fixes #___.

Explanation of Changes

🤖[deprecated] Generated by Copilot at 2a206e7

  • Simplify the rendering of the default slot in the BasicCellRender component by using the renderSlot function from vue (link, link)

Copy link

👋 @FrontEndDog, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

Copy link

github-actions bot commented Dec 4, 2023

Copy link

github-actions bot commented Dec 4, 2023

Hello @FrontEndDog, thank you for contributing to element-plus, please see our guideline to see how to make contribution

Copy link

github-actions bot commented Dec 4, 2023

🧪 Playground Preview: https://element-plus.run/?pr=15036
Please comment the example via this playground if needed.

@kooriookami
Copy link
Member

Thanks for your contribution.

@kooriookami kooriookami merged commit 0482d11 into element-plus:dev Dec 5, 2023
13 checks passed
@element-bot element-bot mentioned this pull request Dec 15, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants