feat(components): [menu] add popper-class、subMenuTimeout props
#15193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @zhixiaotong, seems like this is your first time contribution to element-plus.
|
pull-request-triage
bot
added
1st contribution
|
|
|
Hello @zhixiaotong, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
github-actions
bot
added
Contribution::Community
CommitMessage::Qualified
|
🧪 Playground Preview: https://element-plus.run/?pr=15193 |
|
Sorry to bother you. @kooriookami |
kooriookami
requested changes
Dec 20, 2023
|
我命名参考了antd，虽然这个命名有点长吧，但如果只叫show/hide-timeout，会不会不太直观。比如应该是popper的timeout相关。
…---Original---
From: ***@***.***>
Date: Wed, Dec 20, 2023 17:59 PM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [element-plus/element-plus] feat(components): [menu] add `popper-class`、`subMenuTimeout` props (PR #15193)
@kooriookami requested changes on this pull request.
In docs/en-US/component/menu.md:
> +| sub-menu-show-timeout ^(2.4.5) | Control timeout for all sub menus before showing | `number` | — | 300 | +| sub-menu-hide-timeout ^(2.4.5) | Control timeout for all sub menus before hiding | `number` | — | 300 | ⬇️ Suggested change -| sub-menu-show-timeout ^(2.4.5) | Control timeout for all sub menus before showing | `number` | — | 300 | -| sub-menu-hide-timeout ^(2.4.5) | Control timeout for all sub menus before hiding | `number` | — | 300 | +| show-timeout ^(2.4.5) | Control timeout for all menus before showing | `number` | — | 300 | +| hide-timeout ^(2.4.5) | Control timeout for all menus before hiding | `number` | — | 300 |
In docs/en-US/component/menu.md:
> +| sub-menu-show-timeout ^(2.4.5) | Control timeout for all sub menus before showing | `number` | — | 300 | +| sub-menu-hide-timeout ^(2.4.5) | Control timeout for all sub menus before hiding | `number` | — | 300 |
Be short is better.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
The name style of EP is simplified. @chenxch |
Well... follow the design. |
|
@kooriookami @chenxch 麻烦看一下我提的另一个pr，因为工作中需要用到这种特性，就提了这个pr，谢谢啦。#15206 |
chenxch
reviewed
Dec 21, 2023
kooriookami
approved these changes
Dec 21, 2023
chenxch
approved these changes
Dec 21, 2023
|
Please set the version tag to 2.5.0 |
2.5.0是一个占位符吗，方便批量替换成实际的版本？ |
btea
reviewed
Dec 23, 2023
btea
approved these changes
Dec 23, 2023
Nope, the next version is 2.5.0 , perhaps haha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.Description
copilot:summary
Related Issue
Fixes #15149.
Explanation of Changes
copilot:walkthrough