-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(element-plus): Support last 2 versions of browsers #15313
Conversation
🧪 Playground Preview: https://element-plus.run/?pr=15313 |
@chenxch @btea @FrontEndDog What do you think? |
@kooriookami I found that this PR only modifies the document description. If we want to modify the corresponding version compatibility, do we need to modify the build configuration simultaneously? 🤔 |
This is a starting point, we can use the new features to write code later on. I'm refactoring select component now. |
Ok, I see. But I still have a question. Currently, the chrome version we support is |
I referenced other component libraries and wrote it the same way. The latest two versions are not mandatory, just a suggestion. It may work fine with lower versions like |
Do we have specific standards to determine which browser versions should be supported? |
Modern browsers in three years, at least support ES2021. |
@btea Can we merge this PR?It's related to the refactor of select component. |
@kooriookami To be honest, I'm not sure. But if you want to make related adjustments in the future, I think it's okay. 👍 |
OK, just do it. :D |
The big reason I would use element plus over other component libraries is that it clearly defines the minimum supported version, and it's the version that the vast majority of computers are running. I think it would be very irresponsible to say "last two versions supported" as other libraries do. Developers don't know what features are not supported, and it's not clear if element plus will work as expected with the addition of Babel and Polyfill. I hope it would be more appropriate to raise the minimum supported version to a specific version number, like 99. |
We're upgrading the supported browser versions to
last 2 versions
in version2.5.0
. If you want to support the old version browsers, please add Babel and Polyfill yourself, or use element-plus in version2.4.x
.