Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(element-plus): Support last 2 versions of browsers #15313

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

kooriookami
Copy link
Member

We're upgrading the supported browser versions to last 2 versions in version 2.5.0. If you want to support the old version browsers, please add Babel and Polyfill yourself, or use element-plus in version 2.4.x.

Copy link

github-actions bot commented Dec 29, 2023

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Dec 29, 2023
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=15313
Please comment the example via this playground if needed.

@kooriookami
Copy link
Member Author

@chenxch @btea @FrontEndDog What do you think?

@btea
Copy link
Collaborator

btea commented Jan 2, 2024

@kooriookami I found that this PR only modifies the document description. If we want to modify the corresponding version compatibility, do we need to modify the build configuration simultaneously? 🤔

@kooriookami
Copy link
Member Author

kooriookami commented Jan 2, 2024

@kooriookami I see that this PR only modifies the document description. If we want to modify the corresponding version compatibility, do we need to modify the build configuration simultaneously? 🤔

This is a starting point, we can use the new features to write code later on. I'm refactoring select component now.
It's more of a reminder that tells the user the recommended browser version.

@btea
Copy link
Collaborator

btea commented Jan 2, 2024

Ok, I see. But I still have a question. Currently, the chrome version we support is 64+, and the latest chrome version is 120. Is this span too big?

@kooriookami
Copy link
Member Author

Ok, I see. But I still have a question. Currently, the chrome version we support is 64+, and the latest chrome version is 120. Is this span too big?

I referenced other component libraries and wrote it the same way. The latest two versions are not mandatory, just a suggestion. It may work fine with lower versions like 90+.

@btea
Copy link
Collaborator

btea commented Jan 2, 2024

Do we have specific standards to determine which browser versions should be supported?

@kooriookami
Copy link
Member Author

Do we have specific standards to determine which browser versions should be supported?

Modern browsers in three years, at least support ES2021.

@kooriookami
Copy link
Member Author

@btea Can we merge this PR?It's related to the refactor of select component.

@btea
Copy link
Collaborator

btea commented Jan 5, 2024

@kooriookami To be honest, I'm not sure. But if you want to make related adjustments in the future, I think it's okay. 👍

@kooriookami
Copy link
Member Author

OK, just do it. :D

@xiaoxian521 xiaoxian521 merged commit 2bb71f6 into dev Jan 5, 2024
10 checks passed
@xiaoxian521 xiaoxian521 deleted the feat/browser-version branch January 5, 2024 14:55
@element-bot element-bot mentioned this pull request Jan 10, 2024
3 tasks
@TheNovemberRain
Copy link

The big reason I would use element plus over other component libraries is that it clearly defines the minimum supported version, and it's the version that the vast majority of computers are running. I think it would be very irresponsible to say "last two versions supported" as other libraries do. Developers don't know what features are not supported, and it's not clear if element plus will work as expected with the addition of Babel and Polyfill. I hope it would be more appropriate to raise the minimum supported version to a specific version number, like 99.

@FrontEndDog FrontEndDog mentioned this pull request Jan 17, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants