Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): fixed total column without background color #15336

Merged
merged 6 commits into from
Jan 8, 2024
Merged

fix(components): fixed total column without background color #15336

merged 6 commits into from
Jan 8, 2024

Conversation

wjp980108
Copy link
Contributor

fix #15324

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage Pull Request Triage
Copy link

👋 @SeaAster, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Jan 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024

Hello @SeaAster, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jan 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=15336
Please comment the example via this playground if needed.

wjp980108 and others added 2 commits January 3, 2024 20:45
@wjp980108 @btea
Update packages/theme-chalk/src/table.scss
9764c2b 
Indeed & it is redundant

Co-authored-by: btea <2356281422@qq.com>
@wjp980108
Merge branch 'dev' into dev
4a6878e
@wjp980108
Copy link
Contributor Author

🧪 Playground Preview

@wjp980108
Copy link
Contributor Author

@btea Updated it

@btea
Copy link
Collaborator

btea commented Jan 5, 2024

@SeaAster If there are no code conflicts, there is no need to merge the dev branch content. 😄

@wjp980108
Copy link
Contributor Author

@SeaAster If there are no code conflicts, there is no need to merge the dev branch content. 😄

Okay, I will pay attention to it in the future 😁

@wjp980108
Copy link
Contributor Author

@btea When do you plan to merge this PR? 🤔

FrontEndDog
FrontEndDog approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@FrontEndDog FrontEndDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks！

@FrontEndDog FrontEndDog merged commit 2664188 into element-plus:dev Jan 8, 2024
8 checks passed
@wjp980108
Copy link
Contributor Author

谢谢！

😁

@wjp980108 wjp980108 deleted the dev branch January 8, 2024 14:36
@element-bot element-bot mentioned this pull request Jan 10, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

@FrontEndDog FrontEndDog FrontEndDog approved these changes

Assignees

@wjp980108 wjp980108

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
3 participants
@wjp980108 @btea @FrontEndDog