Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [input] remove useless contants #15351

Merged
merged 2 commits into from
Jan 4, 2024
Merged

fix(components): [input] remove useless contants #15351

merged 2 commits into from
Jan 4, 2024

Conversation

pzzyf
Copy link
Contributor

@pzzyf pzzyf commented Jan 4, 2024

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage Pull Request Triage
Copy link

👋 @pzzyf, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Jan 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024 •
edited

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024

Hello @pzzyf, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@pzzyf
Copy link
Contributor Author

pzzyf commented Jan 4, 2024

cc @chenxch @kooriookami

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jan 4, 2024
chenxch
chenxch approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@chenxch chenxch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=15351
Please comment the example via this playground if needed.

@pzzyf
Copy link
Contributor Author

pzzyf commented Jan 4, 2024

@kooriookami

@kooriookami
Copy link
Member

LGTM

@kooriookami kooriookami merged commit 49ca14f into element-plus:dev Jan 4, 2024
8 checks passed
@pzzyf pzzyf deleted the chore-remove-useless-contants branch January 4, 2024 13:39
@element-bot element-bot mentioned this pull request Jan 10, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenxch chenxch chenxch approved these changes

@btea btea btea approved these changes

@kooriookami kooriookami kooriookami approved these changes

Assignees

@pzzyf pzzyf

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pzzyf @kooriookami @chenxch @btea