fix(components): [image, image-viewer] Add crossorigin property #15406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @wkasunsampath, seems like this is your first time contribution to element-plus.
|
pull-request-triage
bot
added
1st contribution
|
|
|
Hello @wkasunsampath, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
github-actions
bot
added
Contribution::Community
CommitMessage::Qualified
kooriookami
approved these changes
Jan 8, 2024
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with different origins, image loading is failed with
net::ERR_BLOCKED_BY_RESPONSE.NotSameOrigin 200 (OK)error. This PR is to fix that issue by adding crossorigin property to image and image viewer.devbranch.