Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [select] style break change in multiple collapseTags #15460

Merged
merged 3 commits into from
Jan 15, 2024

Conversation

Fuphoenixes
Copy link
Contributor

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

fixed: #15459

Copy link

👋 @Fuphoenixes, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

Copy link

github-actions bot commented Jan 11, 2024

Copy link

Hello @Fuphoenixes, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@Fuphoenixes
Copy link
Contributor Author

@kooriookami see see

Copy link

github-actions bot commented Jan 11, 2024

🧪 Playground Preview: https://element-plus.run/?pr=15460
Please comment the example via this playground if needed.

@xiaoxian521
Copy link
Member

el-select-v2 also has the same problem

image

@kooriookami
Copy link
Member

Yes, please add this feature to select-v2 too.

@Fuphoenixes
Copy link
Contributor Author

done.

@kooriookami
Copy link
Member

Nice~

@Fuphoenixes
Copy link
Contributor Author

Wait, I found a problem.
image
what happened?

@kooriookami
Copy link
Member

kooriookami commented Jan 15, 2024

Oh, I see, when the select size changed, the popover should be updated. Can you fix it?
image

@Fuphoenixes
Copy link
Contributor Author

ok

@kooriookami kooriookami merged commit a01b05d into element-plus:dev Jan 15, 2024
8 checks passed
@element-bot element-bot mentioned this pull request Jan 19, 2024
3 tasks
@Fuphoenixes Fuphoenixes deleted the select branch January 29, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants