fix(components): [table] row has rowspan when hover it only has background on the first row of this rowspan #15529

dowinweb · 2024-01-16T03:11:16Z

table row has rowspan when hover it only has background on the first row of this rowspan
the other rows of which share the rowspan should also give the background of this cell when hover the other rows
Please make sure these boxes are checked before submitting your PR, thank you!

fix #15384

Make sure you follow contributing guide English | (中文 | Español | Français).
Make sure you are merging your commits to dev branch.
Add some descriptions and refer to relative issues for your PR.

table row has rowspan when hover it only has background on the first row of this colspan

pull-request-triage · 2024-01-16T03:11:22Z

👋 @dowinweb, seems like this is your first time contribution to element-plus.

Please make sure that you have read our guidelines and code of conduct before making a contribution.
You can comment with /label Components:[component_name] to add a label for which component you are working on.
You may join our for staying tuned.

github-actions · 2024-01-16T03:11:27Z

github-actions · 2024-01-16T03:11:28Z

Hello @dowinweb, thank you for contributing to element-plus, please see our guideline to see how to make contribution

dowinweb · 2024-01-16T03:13:06Z

fixed [Style] [table] el-table表合并之后，鼠标移动上去样式错误 #15384

dowinweb · 2024-01-16T03:19:53Z

need the ID column also has the background of the hover row

dowinweb · 2024-01-17T06:04:42Z

@btea 大佬麻烦帮看下项目table hover时候有问题急需修复下

github-actions · 2024-01-17T12:23:14Z

🧪 Playground Preview: https://element-plus.run/?pr=15529
Please comment the example via this playground if needed.

btea · 2024-01-17T14:15:28Z

cc @element-plus/backers

dowinweb · 2024-01-17T14:39:39Z

cc @kooriookami

dowinweb · 2024-01-17T14:55:52Z

example

FrontEndDog · 2024-01-18T01:40:21Z

感谢你的贡献，我认为鼠标悬浮在合并的单元格的时候，应该将合并的单元格所在的行都填充背景色，这样更符合直觉一些。

Thank you for your contribution, I think when hovering over merged cells, it is more intuitive to fill the rows of merged cells with background color.

fixed when hover on a rowspan > 1 cell give the whole rows background

dowinweb · 2024-01-18T06:09:09Z

感谢你的贡献，我认为鼠标悬浮在合并的单元格的时候，应该将合并的单元格所在的行都填充背景色，这样更符合直觉一些。

Thank you for your contribution, I think when hovering over merged cells, it is more intuitive to fill the rows of merged cells with background color.

You are right. I have fixed this.

dowinweb · 2024-01-18T06:13:33Z

@FrontEndDog At first i finish this by writing code in the watch hoverRow method, but when you move your mouse from the first row of the merged cell rows, to the merged cell who has rowSan > 1, it didnot trigger the watch method, because the hoverRow didnot change. so i have to do this in the cell event listeners.

dowinweb · 2024-01-20T03:35:48Z

@FrontEndDog bro, can this be merged ? any more suggestions?

packages/components/table/src/table-body/events-helper.ts

fixed hover on merged cell give the background of the whole rows

import addClass removeClass

dowinweb · 2024-01-21T14:41:45Z

@btea anything else need to fix

packages/components/table/src/table-body/events-helper.ts

add test case for hover on rowspan > 2

dowinweb · 2024-01-22T07:43:52Z

如果可以加一下相关的测试用例，就更好了

It would be even better if you could add a test case!

OK already added test case
@FrontEndDog take a look if its ok

dowinweb · 2024-01-23T07:55:18Z

tell me if there is anything else to change @btea @FrontEndDog

packages/components/table/__tests__/table.test.ts

use getTestData is better

use getTestData instead

change templete label prop

FrontEndDog

Thank you for your contribution!

packages/components/table/src/table-body/index.ts

dowinweb · 2024-01-31T03:16:12Z

@btea can this be merged? 😃 need to fix any other things?🤨

packages/components/table/src/table-body/index.ts

drop comments and clear hoveredCell array after use

tolking · 2024-02-01T14:43:23Z

当表格包含固定列同时 rowspan>2 时，样式会出错

鼠标在非 ID 的列上下移动 BUG

when there is fixed row, hover on rowSpan > 1 should not clear the class

dowinweb · 2024-02-01T16:17:42Z

当表格包含固定列同时 rowspan>2 时，样式会出错

鼠标在非 ID 的列上下移动 BUG

不得不说行固定的时候执行的有点奇怪，我去标记了固定时候的行，以避免被清空行样式，我觉得修复好了可以测试下
I have to say that row with fixed works a little bit strange with the code process , i have to mark the row with fixed class to avoid the remove of the row background class， i think this is fixed, you can test it.

@tolking see if there is other conditions and boundary situations to test

dowinweb · 2024-02-04T13:38:31Z

@tolking what do i need to do now

tolking

LGTM.

Thank for your contribution

fix(components): table

24db59b

table row has rowspan when hover it only has background on the first row of this colspan

pull-request-triage bot assigned dowinweb Jan 16, 2024

pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Jan 16, 2024

github-actions bot added the Contribution::Community label Jan 16, 2024

dowinweb changed the title ~~fix(components): table~~ fix(components): table [row has rowspan when hover it only has background on the first row of this colspan] Jan 16, 2024

dowinweb changed the title ~~fix(components): table [row has rowspan when hover it only has background on the first row of this colspan]~~ fix(components): table [row has rowspan when hover it only has background on the first row of this rowspan] Jan 16, 2024

dowinweb changed the title ~~fix(components): table [row has rowspan when hover it only has background on the first row of this rowspan]~~ fix(components): [table] row has rowspan when hover it only has background on the first row of this rowspan Jan 16, 2024

Merge branch 'dev' into dev

6527c58

github-actions bot added the CommitMessage::Qualified Qualified commit message label Jan 17, 2024

fix(components): table

f78f9d9

fixed when hover on a rowspan > 1 cell give the whole rows background

btea reviewed Jan 20, 2024

View reviewed changes

packages/components/table/src/table-body/events-helper.ts Show resolved Hide resolved

dwaynewdong and others added 2 commits January 20, 2024 14:41

fix(components): [table]

dee1175

fixed hover on merged cell give the background of the whole rows

Update events-helper.ts

a050309

import addClass removeClass

FrontEndDog requested changes Jan 21, 2024

View reviewed changes

packages/components/table/src/table-body/events-helper.ts Outdated Show resolved Hide resolved

fix(components): [table]

7f9fe2c

add test case for hover on rowspan > 2

Merge branch 'element-plus:dev' into dev

852cdd8

FrontEndDog requested changes Jan 23, 2024

View reviewed changes

packages/components/table/__tests__/table.test.ts Outdated Show resolved Hide resolved

dwaynewdong and others added 4 commits January 23, 2024 22:17

fix(components): [table]

54dc76d

use getTestData is better

Merge branch 'element-plus:dev' into dev

2645fbe

Update table.test.ts

3ece4ff

use getTestData instead

Update table.test.ts

46efd34

change templete label prop

FrontEndDog approved these changes Jan 24, 2024

View reviewed changes

btea reviewed Jan 24, 2024

View reviewed changes

packages/components/table/src/table-body/index.ts Show resolved Hide resolved

Merge branch 'dev' of github.com:dowinweb/element-plus into dev

106a564

dowinweb added 3 commits January 31, 2024 11:19

Merge branch 'dev' into dev

0488d1e

Merge branch 'dev' into dev

c2431cc

Merge branch 'dev' into dev

411b96d

dowinweb requested a review from btea February 1, 2024 02:16

btea reviewed Feb 1, 2024

View reviewed changes

packages/components/table/src/table-body/index.ts Show resolved Hide resolved

packages/components/table/src/table-body/index.ts Outdated Show resolved Hide resolved

dwaynewdong added 2 commits February 1, 2024 10:54

fix(components): [table]

b3987ed

drop comments and clear hoveredCell array after use

Merge branch 'dev' of github.com:dowinweb/element-plus into dev

3ab2cd3

btea approved these changes Feb 1, 2024

View reviewed changes

btea requested a review from tolking February 1, 2024 05:38

fix(components): [table]

454bfb0

when there is fixed row, hover on rowSpan > 1 should not clear the class

Merge branch 'dev' into dev

23ad887

tolking approved these changes Feb 4, 2024

View reviewed changes

tolking merged commit d2fbff7 into element-plus:dev Feb 4, 2024
8 checks passed

element-bot mentioned this pull request Feb 18, 2024

D2M #15862

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(components): [table] row has rowspan when hover it only has background on the first row of this rowspan #15529

fix(components): [table] row has rowspan when hover it only has background on the first row of this rowspan #15529

dowinweb commented Jan 16, 2024 •

edited by btea

pull-request-triage bot commented Jan 16, 2024

github-actions bot commented Jan 16, 2024 •

edited

github-actions bot commented Jan 16, 2024

dowinweb commented Jan 16, 2024 •

edited

dowinweb commented Jan 16, 2024 •

edited

dowinweb commented Jan 17, 2024

github-actions bot commented Jan 17, 2024 •

edited

btea commented Jan 17, 2024

dowinweb commented Jan 17, 2024

dowinweb commented Jan 17, 2024

FrontEndDog commented Jan 18, 2024

dowinweb commented Jan 18, 2024 •

edited

dowinweb commented Jan 18, 2024 •

edited

dowinweb commented Jan 20, 2024

dowinweb commented Jan 21, 2024

dowinweb commented Jan 22, 2024 •

edited

dowinweb commented Jan 23, 2024

FrontEndDog left a comment

dowinweb commented Jan 31, 2024 •

edited

tolking commented Feb 1, 2024

dowinweb commented Feb 1, 2024 •

edited

dowinweb commented Feb 4, 2024

tolking left a comment •

edited

fix(components): [table] row has rowspan when hover it only has background on the first row of this rowspan #15529

fix(components): [table] row has rowspan when hover it only has background on the first row of this rowspan #15529

Conversation

dowinweb commented Jan 16, 2024 • edited by btea

pull-request-triage bot commented Jan 16, 2024

github-actions bot commented Jan 16, 2024 • edited

github-actions bot commented Jan 16, 2024

dowinweb commented Jan 16, 2024 • edited

dowinweb commented Jan 16, 2024 • edited

dowinweb commented Jan 17, 2024

github-actions bot commented Jan 17, 2024 • edited

btea commented Jan 17, 2024

dowinweb commented Jan 17, 2024

dowinweb commented Jan 17, 2024

FrontEndDog commented Jan 18, 2024

dowinweb commented Jan 18, 2024 • edited

dowinweb commented Jan 18, 2024 • edited

dowinweb commented Jan 20, 2024

dowinweb commented Jan 21, 2024

dowinweb commented Jan 22, 2024 • edited

dowinweb commented Jan 23, 2024

FrontEndDog left a comment

Choose a reason for hiding this comment

dowinweb commented Jan 31, 2024 • edited

tolking commented Feb 1, 2024

dowinweb commented Feb 1, 2024 • edited

dowinweb commented Feb 4, 2024

tolking left a comment • edited

Choose a reason for hiding this comment

dowinweb commented Jan 16, 2024 •

edited by btea

github-actions bot commented Jan 16, 2024 •

edited

dowinweb commented Jan 16, 2024 •

edited

dowinweb commented Jan 16, 2024 •

edited

github-actions bot commented Jan 17, 2024 •

edited

dowinweb commented Jan 18, 2024 •

edited

dowinweb commented Jan 18, 2024 •

edited

dowinweb commented Jan 22, 2024 •

edited

dowinweb commented Jan 31, 2024 •

edited

dowinweb commented Feb 1, 2024 •

edited

tolking left a comment •

edited