Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components): [select & select-v2] Add loading slot #15540

Merged
merged 2 commits into from
Jan 18, 2024
Merged

feat(components): [select & select-v2] Add loading slot #15540

merged 2 commits into from
Jan 18, 2024

Conversation

kooriookami
Copy link
Member

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2024 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jan 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2024 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=15540
Please comment the example via this playground if needed.

@xiaoxian521 xiaoxian521 self-requested a review January 16, 2024 14:22
FrontEndDog
FrontEndDog requested changes Jan 17, 2024
View reviewed changes
Copy link
Member

@FrontEndDog FrontEndDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.Before loading appears, No Data will appear, I think the dropdownMenu should appear after input debounce.
2.I found a bug, Input 1111111, The front 1 will be covered

2024-01-17.10.25.04.mov

@kooriookami
Copy link
Member Author

1.Before loading appears, No Data will appear, I think the dropdownMenu should appear after input debounce. 2.I found a bug, Input 1111111, The front 1 will be covered

2024-01-17.10.25.04.mov

  1. Sounds good, maybe ask other people
  2. Fixed by style(theme-chalk): [select] Fix style when calculate input width #15539

@kooriookami
Copy link
Member Author

@FrontEndDog I added the dropdowm menu shows after loading. Look look.

FrontEndDog
FrontEndDog approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@FrontEndDog FrontEndDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FrontEndDog FrontEndDog merged commit feb169f into dev Jan 18, 2024
8 checks passed
@FrontEndDog FrontEndDog deleted the feat/select-v1-v2-loading branch January 18, 2024 04:23
@element-bot element-bot mentioned this pull request Jan 19, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoxian521 xiaoxian521 xiaoxian521 approved these changes

@FrontEndDog FrontEndDog FrontEndDog approved these changes

Assignees

@kooriookami kooriookami

Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kooriookami @xiaoxian521 @FrontEndDog