-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): [tour] target prop add more type #15578
Conversation
👋 @Fuphoenixes, thank you for contributing element-plus. |
Hello @Fuphoenixes, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
@kooriookami see see |
🧪 Playground Preview: https://element-plus.run/?pr=15578 |
Can you provide a playground demo :D |
LGTM. Special thanks to you for your contribution like Watermark and Tour. By the way, I'm wondering if you'd be interested in making a new Anchor component. If you have any idea, please contact me. |
Yes I do |
Do you have a email? I'll send my wechat number to you. |
Perhaps we could add an example where the target value is a string or a function, and then add a version tag to indicate which version supports the feature. |
done. |
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.