Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): [tour] target prop add more type #15578

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

Fuphoenixes
Copy link
Contributor

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Copy link

👋 @Fuphoenixes, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

Copy link

github-actions bot commented Jan 18, 2024

Copy link

Hello @Fuphoenixes, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@Fuphoenixes
Copy link
Contributor Author

@kooriookami see see

Copy link

github-actions bot commented Jan 18, 2024

🧪 Playground Preview: https://element-plus.run/?pr=15578
Please comment the example via this playground if needed.

@kooriookami
Copy link
Member

kooriookami commented Jan 18, 2024

Can you provide a playground demo :D

@Fuphoenixes
Copy link
Contributor Author

playground demo

@kooriookami
Copy link
Member

kooriookami commented Jan 18, 2024

LGTM. Special thanks to you for your contribution like Watermark and Tour. By the way, I'm wondering if you'd be interested in making a new Anchor component. If you have any idea, please contact me.

docs/en-US/component/tour.md Outdated Show resolved Hide resolved
@Fuphoenixes
Copy link
Contributor Author

LGTM. Special thanks to you for your contribution like Watermark and Tour. By the way, I'm wondering if you'd be interested in making a new Anchor component. If you have any idea, please contact me.

Yes I do

@kooriookami
Copy link
Member

LGTM. Special thanks to you for your contribution like Watermark and Tour. By the way, I'm wondering if you'd be interested in making a new Anchor component. If you have any idea, please contact me.

Yes I do

Do you have a email? I'll send my wechat number to you.

@Fuphoenixes
Copy link
Contributor Author

657454579@qq.com

docs/en-US/component/tour.md Outdated Show resolved Hide resolved
@btea
Copy link
Collaborator

btea commented Jan 18, 2024

Perhaps we could add an example where the target value is a string or a function, and then add a version tag to indicate which version supports the feature.

@Fuphoenixes
Copy link
Contributor Author

Perhaps we could add an example where the target value is a string or a function, and then add a version tag to indicate which version supports the feature.

done.

@btea btea merged commit a4c17ee into element-plus:dev Jan 19, 2024
8 checks passed
@element-bot element-bot mentioned this pull request Jan 19, 2024
3 tasks
@Fuphoenixes Fuphoenixes deleted the tour branch January 25, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants