Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [carousel] improve a11y #15579

Merged
merged 6 commits into from Feb 3, 2024
Merged

fix(components): [carousel] improve a11y #15579

merged 6 commits into from Feb 3, 2024

Conversation

cloydlau
Copy link
Contributor

@cloydlau cloydlau commented Jan 18, 2024 •
edited

Please make sure these boxes are checked before submitting your PR, thank you!

  • [✓] Make sure you follow contributing guide English | (中文 | Español | Français).
  • [✓] Make sure you are merging your commits to dev branch.
  • [✓] Add some descriptions and refer to relative issues for your PR.

When running the Lighthouse of Chrome, it throws 'Buttons do not have an accessible name':

image

@pull-request-triage Pull Request Triage
Copy link

👋 @cloydlau, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Jan 18, 2024
@github-actions GitHub Actions
Copy link

Hello @cloydlau, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 18, 2024 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jan 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 18, 2024 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=15579
Please comment the example via this playground if needed.

btea
btea approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tolking tolking merged commit 73f4d0f into element-plus:dev Feb 3, 2024
8 checks passed
@element-bot element-bot mentioned this pull request Feb 18, 2024
Merged
3 tasks
@btea btea mentioned this pull request Mar 10, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolking tolking tolking approved these changes

@btea btea btea approved these changes

Assignees

@cloydlau cloydlau

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cloydlau @tolking @btea