Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [select] Remote search does not show menu when it has options and no query #15683

Merged
merged 3 commits into from Jan 26, 2024
Merged

fix(components): [select] Remote search does not show menu when it has options and no query #15683

merged 3 commits into from Jan 26, 2024

Conversation

wen403
Copy link
Contributor

@wen403 wen403 commented Jan 25, 2024 •
edited by kooriookami

When remote search is enabled, the menu does not appear after focusing.

Closes #15679

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage Pull Request Triage
Copy link

👋 @wen403, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Jan 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 25, 2024 •
edited

@github-actions GitHub Actions
Copy link

Hello @wen403, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@kooriookami
Copy link
Member

Please modify SelectV2 too.

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jan 26, 2024
@kooriookami kooriookami changed the title fix(components): [select] Remote search does not show menu fix(components): [select] Remote search does not show menu when it has options and no query Jan 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 26, 2024 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=15683
Please comment the example via this playground if needed.

@kooriookami
Copy link
Member

LGTM

@kooriookami kooriookami merged commit 1f6537a into element-plus:dev Jan 26, 2024
8 checks passed
@purepear purepear mentioned this pull request Jan 30, 2024
Closed
@element-bot element-bot mentioned this pull request Feb 2, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kooriookami kooriookami kooriookami approved these changes

Assignees

@wen403 wen403

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [select, select-v2] 开启远程搜索时候，不加载默认Options的数据
2 participants
@wen403 @kooriookami