Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): overlay error caused by sidebar #15694

Merged
merged 1 commit into from Jan 27, 2024
Merged

fix(docs): overlay error caused by sidebar #15694

merged 1 commit into from Jan 27, 2024

Conversation

heygsc
Copy link
Contributor

@heygsc heygsc commented Jan 26, 2024

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

When at normal width, click to expand the sidebar. Overlay will cover a part of it, but expose the sidebar.
image
But if the sidebar is also covered at certain widths, it should be displayed as usual.
image

@pull-request-triage Pull Request Triage
Copy link

👋 @heygsc, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Jan 26, 2024
@github-actions GitHub Actions
Copy link

Hello @heygsc, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 26, 2024 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jan 27, 2024
@github-actions GitHub Actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=15694
Please comment the example via this playground if needed.

@btea btea changed the title fix: overlay error caused by sidebar fix(docs): overlay error caused by sidebar Jan 27, 2024
btea
btea approved these changes Jan 27, 2024
View reviewed changes
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! ❤️

@btea btea merged commit cf9c936 into element-plus:dev Jan 27, 2024
10 checks passed
@heygsc
Copy link
Contributor Author

heygsc commented Jan 27, 2024 •
edited

Thank you for your contribution! ❤️

Thank you!

@heygsc heygsc deleted the sidebar branch January 27, 2024 11:17
@element-bot element-bot mentioned this pull request Feb 2, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolking tolking tolking approved these changes

@btea btea btea approved these changes

Assignees

@heygsc heygsc

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@heygsc @tolking @btea