fix(image): fix image Add the dom of the preview picture to the body #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Would you mind adding the added API to the documentation? |
…,added documentation
|
adding the added API to the documentation |
jw-foss
reviewed
Mar 11, 2021
| @@ -173,9 +173,10 @@ Besides the native features of img, support lazy load, custom placeholder and lo | |||
| | initial-index | The initial preview image index, less than or equal to the length of `url-list` | number | int | 0 | | |||
| | infinite | Whether preview is infinite | boolean | true / false | true | | |||
| | hide-on-click-modal | Whether user can emit close event when clicking backdrop | boolean | true / false | false | | |||
| | append-to-body | whether to append image itself to body. A nested parent element attribute transform should have this attribute set to `true` | boolean | — | false | | |||
There was a problem hiding this comment.
Please copy paste this attribute description to fr es jp as well. ;)
There was a problem hiding this comment.
description to fr es jp
…,added documentation, description to fr es jp
jw-foss
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.当image 在Carousel组件里用,fixed定位受到transform影响不能再视口定位的bug