Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(components): [message] Update message style #15912

Merged
merged 2 commits into from Feb 23, 2024
Merged

style(components): [message] Update message style #15912

merged 2 commits into from Feb 23, 2024

Conversation

kooriookami
Copy link
Member

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2024 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Feb 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2024 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=15912
Please comment the example via this playground if needed.

ryuhangyeong
ryuhangyeong reviewed Feb 22, 2024
View reviewed changes
Copy link
Member

@ryuhangyeong ryuhangyeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a reference design (figma)?

@kooriookami
Copy link
Member Author

It's the 40px height system of message, the same with the height of alert. And the gap of messages is 16px the same with notification.

@kooriookami kooriookami merged commit d1a7fd1 into dev Feb 23, 2024
8 checks passed
@kooriookami kooriookami deleted the style/message branch February 23, 2024 08:23
@element-bot element-bot mentioned this pull request Mar 1, 2024
Merged
3 tasks
@HammCn
Copy link

HammCn commented Mar 13, 2024 •
edited

Are you kidding me???

It's the worst thing when change the style codes of the UI library especially some of the styles have been rewritten to fit their own UI styles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryuhangyeong ryuhangyeong ryuhangyeong approved these changes

Assignees

@kooriookami kooriookami

Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kooriookami @HammCn @ryuhangyeong