Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(components): [datetime-picker] update calculation of shortcut key values #16316

Merged
merged 1 commit into from
Mar 29, 2024
Merged

docs(components): [datetime-picker] update calculation of shortcut key values #16316

merged 1 commit into from
Mar 29, 2024

Conversation

HengYuLuck
Copy link
Contributor

@HengYuLuck HengYuLuck commented Mar 29, 2024 •
edited

[date-picker] update calculation of shortcut key value

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@HengYuLuck
Update date-and-time.vue
3da900a 
[date-picker] update calculation of shortcut key value
@pull-request-triage Pull Request Triage
Copy link

👋 @HengYuLuck, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Mar 29, 2024
@github-actions GitHub Actions
Copy link

Hello @HengYuLuck, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 29, 2024 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Mar 29, 2024
@github-actions GitHub Actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=16316
Please comment the example via this playground if needed.

@btea btea changed the title Update date-and-time.vue docs(components): [datetime-picker] update calculation of shortcut key values Mar 29, 2024
btea
btea approved these changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@btea btea merged commit 36ebbc7 into element-plus:dev Mar 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

Assignees

@HengYuLuck HengYuLuck

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HengYuLuck @btea