Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 update autocomplete default width #16633

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

xxholly32
Copy link
Sponsor Contributor

@xxholly32 xxholly32 commented Apr 24, 2024

Closes: 16619

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Copy link

👋 @xxholly32, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Apr 24, 2024
Copy link

github-actions bot commented Apr 24, 2024

Copy link

Hello @xxholly32, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Apr 24, 2024
Copy link

github-actions bot commented Apr 24, 2024

🧪 Playground Preview: https://element-plus.run/?pr=16633
Please comment the example via this playground if needed.

Copy link
Member

@kooriookami kooriookami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use getCssVar('input-width') is better.

@xxholly32
Copy link
Sponsor Contributor Author

@kooriookami see if its OK, ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] [autocomplete] For autocomplete, the presentation and input will be inconsistent without width
2 participants