Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add guide for on-demand import with Rspack #16841

Merged
merged 2 commits into from
May 13, 2024
Merged

docs: add guide for on-demand import with Rspack #16841

merged 2 commits into from
May 13, 2024

Conversation

chenjiahan
Copy link
Contributor

The unplugin also supports Rspack.

This PR adds Rspack config example to the documentation to help users use Element Plus in Rspack projects.

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage Pull Request Triage
Copy link

👋 @chenjiahan, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels May 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited

@github-actions GitHub Actions
Copy link

Hello @chenjiahan, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions GitHub Actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=16841
Please comment the example via this playground if needed.

btea
btea approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@btea btea merged commit c2843cd into element-plus:dev May 13, 2024
10 checks passed
@chenjiahan chenjiahan deleted the quick_start_rspack_example_0513 branch May 13, 2024 12:46
0song added a commit that referenced this pull request May 31, 2024
@0song
Revert "docs: add guide for on-demand import with Rspack (#16841)"
07cdb93 
This reverts commit c2843cd.
@0song 0song mentioned this pull request May 31, 2024
Merged
0song added a commit that referenced this pull request May 31, 2024
@0song
Revert "docs: add guide for on-demand import with Rspack" (#17042)
17ef1fe 
Revert "docs: add guide for on-demand import with Rspack (#16841)"

This reverts commit c2843cd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

Assignees

@chenjiahan chenjiahan

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chenjiahan @btea