Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: [select] add width tip eg link #16973

Merged
merged 1 commit into from
May 26, 2024
Merged

docs: [select] add width tip eg link #16973

merged 1 commit into from
May 26, 2024

Conversation

warmthsea
Copy link
Contributor

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

image

@pull-request-triage Pull Request Triage
Copy link

👋 @warmthsea, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions GitHub Actions
Copy link

Hello @warmthsea, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions GitHub Actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=16973
Please comment the example via this playground if needed.

btea
btea approved these changes May 25, 2024
View reviewed changes
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. What do you think? @kooriookami

@kooriookami
Copy link
Member

I think it's okay.

@btea btea merged commit 99278b7 into element-plus:dev May 26, 2024
11 checks passed
@warmthsea warmthsea deleted the docs/select branch May 26, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

Assignees

@warmthsea warmthsea

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@warmthsea @kooriookami @btea