Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): [image] fix placeholder demo #17245

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

makedopamine
Copy link
Contributor

In lower version of Vue Macros, there is a bug in hoistStatic feature that causes the issue.

Before:
image

After:
image

Copy link

👋 @makedopamine, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

Copy link

github-actions bot commented Jun 17, 2024

Copy link

Hello @makedopamine, thank you for contributing to element-plus, please see our guideline to see how to make contribution

Copy link

🧪 Playground Preview: https://element-plus.run/?pr=17245
Please comment the example via this playground if needed.

@btea btea requested a review from sxzz June 17, 2024 12:32
@warmthsea
Copy link
Contributor

Using ref can also solve this problem of docs.

4e6a139392d34f80c720a00660d15d72

@makedopamine
Copy link
Contributor Author

True, it works as ref() is a CallExpression AST node that won't be hoisted. Even though it's sort of a workaround in this case, we'd better not fix the issue in this way, because the issue will remain in the code base as a potential problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants