Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [time-picker] fix click outside, mishandles handleOpen #17276

Conversation

Panzer-Jack
Copy link
Contributor

@Panzer-Jack Panzer-Jack commented Jun 19, 2024

修复 time-picker 通过点击空白处确认修改时 handleOpen 执行时机问题
Fixes: #17237

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

修复前:
bef

修复后:
aft

Copy link

👋 @Panzer-Jack, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Jun 19, 2024
Copy link

Copy link

Hello @Panzer-Jack, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@Panzer-Jack Panzer-Jack force-pushed the fix/time-picker-confirm-modifications-in-blank-space branch from 58cb19e to 09ee17e Compare June 28, 2024 03:11
@Panzer-Jack Panzer-Jack deleted the fix/time-picker-confirm-modifications-in-blank-space branch June 28, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] [time-picker] 支持通过点击空白处确认修改,但是没有正确处理 handleOpen()
1 participant