Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(message-box): messageBox should close when press enter #2308

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

binvb
Copy link
Contributor

@binvb binvb commented Jun 23, 2021

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

reference:
#2289

Edit by Jeremy

@element-bot
Copy link
Member

@jw-foss
Copy link
Member

jw-foss commented Jun 25, 2021

Got question on this fix. Have you tested on the case?
I thought this was caused by event bubbling, if you confirm that this was tested on the case, I will then merge this.

@jw-foss jw-foss merged commit 7482789 into element-plus:dev Jun 25, 2021
@Hchenxiao
Copy link

我在调用 confirm的函数 @click.once=“调用事件” 加上once 后 按enter后不会一直出来

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] MessageBox does not close when OK is pressed with Enter key
4 participants