Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select-v2): adjust the trigger conditions of focus and blur event #2650

Merged
merged 1 commit into from
Jul 24, 2021
Merged

fix(select-v2): adjust the trigger conditions of focus and blur event #2650

merged 1 commit into from
Jul 24, 2021

Conversation

msidolphin
Copy link
Collaborator

@msidolphin msidolphin commented Jul 24, 2021 •
edited

The following issues were fixed:

  • Blur event can not be triggered
  • Focus event in the focus state can still be repeatedly triggered
  • The isComposing state is set to false after selecting one in multiple mode
  • The focus event is triggered multiple times when selecting in multiple mode

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@element-bot
Copy link
Member

@msidolphin msidolphin requested a review from jw-foss July 24, 2021 03:15
@jw-foss jw-foss merged commit 80a44d8 into element-plus:dev Jul 24, 2021
@jw-foss
Copy link
Member

jw-foss commented Jul 24, 2021

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jw-foss jw-foss jw-foss approved these changes

Assignees
No one assigned
Labels
release candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@msidolphin @element-bot @jw-foss