New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(var): simplify checkbox var & move transition to root #2729

Merged

jw-foss merged 1 commit into dev from refactor/checkbox-css-var

Jul 28, 2021

Member

YunYouJun commented Jul 27, 2021

use sass:map simplift checkbox css var (too many css var is not necessary)
move transition position to root

Please make sure these boxes are checked before submitting your PR, thank you!

Make sure you follow Element's contributing guide English | (中文 | Español | Français).
Make sure you are merging your commits to dev branch.
Add some descriptions and refer to relative issues for your PR.


          refactor(var): simplify checkbox var & move transition to root

b4bc28e

YunYouJun requested a review from jw-foss

July 27, 2021 15:29

YunYouJun added the Quality::Style Related label

Member

element-bot commented Jul 27, 2021

jw-foss approved these changes

View reviewed changes

jw-foss merged commit c8acaeb into dev

jw-foss deleted the refactor/checkbox-css-var branch

July 28, 2021 01:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment