New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(locale): inject locale for modal like components #2737

Merged

jw-foss merged 1 commit into dev from fix/inject-locale-for-modal-like-components

Jul 28, 2021

Member

jw-foss commented Jul 28, 2021

Add a runtime locale object cache for modal components to use

Please make sure these boxes are checked before submitting your PR, thank you!

Make sure you follow Element's contributing guide English | (中文 | Español | Français).
Make sure you are merging your commits to dev branch.
Add some descriptions and refer to relative issues for your PR.


          fix(locale): inject locale for modal like components

9ecbabd

- Add a runtime locale object cache for modal components to use

jw-foss requested a review from iamkun

July 28, 2021 04:17

jw-foss mentioned this pull request

i18n related issue | 国际化相关问题 #2610

Closed

iamkun approved these changes

View reviewed changes

jw-foss merged commit 3d62592 into dev

jw-foss deleted the fix/inject-locale-for-modal-like-components branch

July 28, 2021 04:20

Member

element-bot commented Jul 28, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment