Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [el-selectv2] add type remove ts error #3480

Merged
merged 2 commits into from
Sep 22, 2021

Conversation

btea
Copy link
Collaborator

@btea btea commented Sep 18, 2021

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@element-bot
Copy link
Member

@sxzz sxzz self-assigned this Sep 18, 2021
@@ -33,7 +34,7 @@ export default defineComponent({
width: Number,
},
setup(props) {
const select = inject(selectV2InjectionKey)
const select = inject(selectV2InjectionKey) as SelectV2Context
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you use as SelectV2Context?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may have made a mistake,there should be consistent with here as any

provide(selectV2InjectionKey, {
props: reactive({
...toRefs(props),
height: API.popupHeight,
}),
onSelect: API.onSelect,
onHover: API.onHover,
onKeyboardNavigate: API.onKeyboardNavigate,
onKeyboardSelect: API.onKeyboardSelect,
} as any)

@btea
Copy link
Collaborator Author

btea commented Sep 22, 2021

@sxzz This PR has any other problems to deal with?

@sxzz sxzz merged commit 53a5194 into element-plus:dev Sep 22, 2021
@element-bot element-bot mentioned this pull request Sep 23, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants