refactor(hooks): refactor hooks #4253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
HerringtonDarkholme
approved these changes
Nov 7, 2021
| if (!isServer) { | ||
| on(document, 'keydown', closeModal) | ||
| } | ||
| if (isClient) useEventListener(document, 'keydown', closeModal) |
There was a problem hiding this comment.
This is not side-effect free. Shall we use some init function instead?
There was a problem hiding this comment.
Are there any side effects of useEventListener? I didn't get your point.
There was a problem hiding this comment.
@HerringtonDarkholme Can you elaborate what the side effect is here?
|
@HerringtonDarkholme Each refactoring corresponds to a commit. I think rebase merge is acceptable. There should be no need for one commit for one pull request. |
jw-foss
reviewed
Nov 24, 2021
packages/hooks/use-timeout/index.ts
Outdated
Comment on lines
6
to
10
| const registerTimeout = (fn: (...args: any[]) => unknown, delay: number) => { | ||
| cancelTimeout() | ||
| ;({ stop } = useTimeoutFn(fn, delay)) | ||
| } | ||
| const cancelTimeout = () => stop?.() |
There was a problem hiding this comment.
I think the usage here is wrong, please refer to the source code to get appropriate invoking method.
sxzz
force-pushed
the
refactor/hooks
branch
3 times, most recently
from
f6d1054
to
27d5959
Compare
jw-foss
reviewed
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.