New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): [el-message] config-provider message max attr #5063
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple comments for you to check, thanks.
packages/components/config-provider/__tests__/config-provider.spec.ts
Outdated
Show resolved
Hide resolved
I think we should discuss how to deal( |
IMO, redundant message should be discarded. If multiple messages are placed in the queue and pop up one by one, the user may switch to other pages, but the code logic is still popping up messages one after another, which will cause confusion. |
But if they are discarded, some important information may be lost? |
I think it depends on the user. If the user thinks the information is important, he can not set the max, or he can set the max a little larger. |
can you test when you use two |
Generally, only one |
You're right. If you can add another |
Do you mean to add multiple |
yes |
Maybe it is better to modify the value of config directly like in the test code? |
I'm just worried about whether multiple |
Okay, I will add unit test about this. |
IMHO, multiple provider is made by the developer, so that it is at their choice to make the call, so that we cannot handle this because they did what they did, that was completely on their own, so that we can just ignore it. Because the specialty about these global items (as designed this way) they should be able to accept that. Or maybe later we can try to pass the context to the call so that we can get the app context. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.feat #4868