New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): [el-rate] rate add size prop #5102
Conversation
@@ -12,6 +12,15 @@ describe('Rate.vue', () => { | |||
expect(stars.length).toEqual(10) | |||
}) | |||
|
|||
test('size', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test case for el-rate
without a size prop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left 2 suggestions for you:
- Update the document
- Removing the checking for size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks. /cc @HerringtonDarkholme
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.