Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refactor backtop to support namespace #5552

Merged
merged 1 commit into from
Jan 23, 2022
Merged

refactor: refactor backtop to support namespace #5552

merged 1 commit into from
Jan 23, 2022

Conversation

iamkun
Copy link
Contributor

@iamkun iamkun commented Jan 22, 2022

Please make sure these boxes are checked before submitting your PR, thank you!
ref : #5374

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@github-actions
Copy link

github-actions bot commented Jan 22, 2022 •
edited

@iamkun iamkun changed the title Refactor/backtop ns refactor: refactor backtop to support namespace Jan 22, 2022
sxzz
sxzz reviewed Jan 22, 2022
View reviewed changes
Copy link
Collaborator

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rebase your commits? (remove revert)

@iamkun iamkun force-pushed the refactor/backtop-ns branch 2 times, most recently from efeb0f7 to 4d8d724 Compare January 23, 2022 06:19
@iamkun
Copy link
Contributor Author

iamkun commented Jan 23, 2022

fixed

@sxzz sxzz merged commit 0ecb3fa into dev Jan 23, 2022
@sxzz sxzz deleted the refactor/backtop-ns branch January 23, 2022 09:53
@element-bot element-bot mentioned this pull request Jan 24, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iamkun @sxzz